Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TRA-207] register vault http queries #1324

Merged
merged 1 commit into from
Apr 3, 2024
Merged

[TRA-207] register vault http queries #1324

merged 1 commit into from
Apr 3, 2024

Conversation

tqin7
Copy link
Contributor

@tqin7 tqin7 commented Apr 3, 2024

Changelist

Register http queries of x/vault

Test Plan

Tested locally

Author/Reviewer Checklist

  • If this PR has changes that result in a different app state given the same prior state and transaction list, manually add the state-breaking label.
  • If the PR has breaking postgres changes to the indexer add the indexer-postgres-breaking label.
  • If this PR isn't state-breaking but has changes that modify behavior in PrepareProposal or ProcessProposal, manually add the label proposal-breaking.
  • If this PR is one of many that implement a specific feature, manually label them all feature:[feature-name].
  • If you wish to for mergify-bot to automatically create a PR to backport your change to a release branch, manually add the label backport/[branch-name].
  • Manually add any of the following labels: refactor, chore, bug.

@linear Linear
Copy link

linear bot commented Apr 3, 2024

TRA-207 register http query routes

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 3, 2024 •
edited
Loading

Walkthrough

The update involves modifications to the dYdX protocol's codebase, specifically targeting the integration with the protocol's API and improving error handling in the system. The changes include updating the HTTP endpoint paths for vault-related queries by removing the /v4 segment to better align with the dYdX protocol's API structure. Additionally, enhanced error handling has been introduced in the vault module to address potential registration failures more effectively.

Changes

Files Change Summary
.../v4-protos/src/codegen/dydxprotocol/vault/query.lcd.ts, proto/dydxprotocol/vault/query.proto Updated HTTP endpoint paths for vault queries, removing /v4 segment.
protocol/x/vault/module.go Added error handling in RegisterGRPCGatewayRoutes to manage registration failure.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Apr 3, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Status

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between be1b8ef and f8757ba.
Files ignored due to path filters (2)
  • protocol/x/vault/types/query.pb.go is excluded by !**/*.pb.go, !**/*.pb.go
  • protocol/x/vault/types/query.pb.gw.go is excluded by !**/*.pb.gw.go, !**/*.pb.gw.go
Files selected for processing (3)
  • indexer/packages/v4-protos/src/codegen/dydxprotocol/vault/query.lcd.ts (1 hunks)
  • proto/dydxprotocol/vault/query.proto (1 hunks)
  • protocol/x/vault/module.go (1 hunks)
Files skipped from review as they are similar to previous changes (3)
  • indexer/packages/v4-protos/src/codegen/dydxprotocol/vault/query.lcd.ts
  • proto/dydxprotocol/vault/query.proto
  • protocol/x/vault/module.go

@tqin7 tqin7 merged commit 1104c18 into main Apr 3, 2024
33 checks passed
@tqin7 tqin7 deleted the tq/tra-207 branch April 3, 2024 18:07
tqin7 added a commit that referenced this pull request Apr 4, 2024
@tqin7
register vault http queries (#1324)
1067cd7
@tqin7
Copy link
Contributor Author

tqin7 commented Apr 4, 2024

@Mergifyio backport release/protocol/v5.x

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 4, 2024 •
edited
Loading

backport release/protocol/v5.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Apr 4, 2024
@tqin7 @mergify
register vault http queries (#1324)
ebcbd0c 
(cherry picked from commit 1104c18)
@mergify mergify bot mentioned this pull request Apr 4, 2024
Merged
6 tasks
tqin7 added a commit that referenced this pull request Apr 4, 2024
@mergify @tqin7
register vault http queries (#1324) (#1335)
019ffe9 
(cherry picked from commit 1104c18)

Co-authored-by: Tian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@vincentwschau vincentwschau vincentwschau approved these changes

Assignees
No one assigned
Labels
indexer proto protocol
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tqin7 @vincentwschau